feat: updated on_block so ef tests pass#1230
Merged
KolbyML merged 8 commits intoReamLabs:masterfrom Feb 20, 2026
Merged
Conversation
…obs and proofs as noted in the spec
…obs and proofs as noted in the spec
…and proofs as noted in the spec
…obs and proofs as noted in the spec
Patchoulis
requested review from
Kayden-ML,
KolbyML and
shariqnaiyer
as code owners
looks good
KolbyML
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
fixes #1192.
How was it fixed?
The final fix in regards to the ef-tests being broken was actually due to our on_block logic being for electra. The solution here was simply to update it to fulu, which included some changes to the test harness for the fork choice test macro in order to accept columns instead of blobs and proofs.
To-Do